Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'mumbai' to chainsToSkip #3523

Merged
merged 1 commit into from
Apr 1, 2024
Merged

add 'mumbai' to chainsToSkip #3523

merged 1 commit into from
Apr 1, 2024

Conversation

nbayindirli
Copy link
Contributor

@nbayindirli nbayindirli commented Apr 1, 2024 •
edited
Loading

Description

  • Adds mumbai to chainsToSkip as a preliminary step for deprecating Polygon Mumbai testnet

Related Issues

@nbayindirli nbayindirli requested a review from yorhodes April 1, 2024 19:08
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2639fe5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nbayindirli nbayindirli mentioned this pull request Apr 1, 2024
Merged
3 tasks
@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

Merging #3523 (2639fe5) into main (d00500f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #3523   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         16      16           
=====================================
  Misses        16      16
Components Coverage Δ
core ∅ <ø> (∅)
hooks ∅ <ø> (∅)
isms ∅ <ø> (∅)
token ∅ <ø> (∅)
middlewares ∅ <ø> (∅)

@nbayindirli nbayindirli merged commit 2093fe4 into main Apr 1, 2024
34 of 35 checks passed
@nbayindirli nbayindirli deleted the noah/skip-mumbai branch April 1, 2024 20:41
nbayindirli added a commit that referenced this pull request Apr 2, 2024
@nbayindirli
feat: deprecate Mumbai testnet (#3521)
38358ec 
### Description

- Removes all reference to Mumbai testnet, since it is soon being
[deprecated](https://polygon.technology/blog/polygon-pos-is-cooking-the-napoli-upgrade-means-better-ux-the-mumbai-testnet-takes-a-bow)
by the Polygon team
- Monorepo docker tag:
https://console.cloud.google.com/gcr/images/abacus-labs-dev/global/hyperlane-monorepo@sha256:d4b44359cae9c4e3bdeb6f965c59d056f7fce72c42069adc0dea038ac600785a/details?authuser=5&project=abacus-labs-dev&tab=info
- Agent docker tag:
https://console.cloud.google.com/gcr/images/abacus-labs-dev/global/hyperlane-agent@sha256:a578d96f7f06721d0b6cd8095d6a1fa5d22f01b59eba3320ee3b1fe34ca3c5df/details?authuser=5&project=abacus-labs-dev&tab=info

### Drive-by changes

- Adds missing Testnet domains, Fuji & BSC Testnet
  - Fix for failing `test-rs` CI check with
```
error[E0004]: non-exhaustive patterns: `chain::KnownHyperlaneDomain::Fuji` and `chain::KnownHyperlaneDomain::BinanceSmartChainTestnet` not covered
   --> hyperlane-core/src/utils.rs:226:15
    |
226 |           match $v {
    |                 ^^ patterns `chain::KnownHyperlaneDomain::Fuji` and `chain::KnownHyperlaneDomain::BinanceSmartChainTestnet` not covered
```

### Related issues
- Dependency on #3523 
- Fixes #1181 

### Backward compatibility

- [x] Backwards compatible
- [x] Requires docker image tags to be added post-build
- [x] Requires agent artifact cleanup in cloud account:
https://www.notion.so/hyperlanexyz/Runbook-83c755f2652943289cf98cd1309487a8?pvs=4#77730653a12f409dacfbd427cab545d3

### Testing

* Build success
* `yarn hyperlane chains list -e testnet` does not return `mumbai`
* fork.sh script success locally
ltyu pushed a commit that referenced this pull request Apr 2, 2024
@nbayindirli @ltyu
feat: deprecate Mumbai testnet (#3521)
3ba0ebe 
### Description

- Removes all reference to Mumbai testnet, since it is soon being
[deprecated](https://polygon.technology/blog/polygon-pos-is-cooking-the-napoli-upgrade-means-better-ux-the-mumbai-testnet-takes-a-bow)
by the Polygon team
- Monorepo docker tag:
https://console.cloud.google.com/gcr/images/abacus-labs-dev/global/hyperlane-monorepo@sha256:d4b44359cae9c4e3bdeb6f965c59d056f7fce72c42069adc0dea038ac600785a/details?authuser=5&project=abacus-labs-dev&tab=info
- Agent docker tag:
https://console.cloud.google.com/gcr/images/abacus-labs-dev/global/hyperlane-agent@sha256:a578d96f7f06721d0b6cd8095d6a1fa5d22f01b59eba3320ee3b1fe34ca3c5df/details?authuser=5&project=abacus-labs-dev&tab=info

### Drive-by changes

- Adds missing Testnet domains, Fuji & BSC Testnet
  - Fix for failing `test-rs` CI check with
```
error[E0004]: non-exhaustive patterns: `chain::KnownHyperlaneDomain::Fuji` and `chain::KnownHyperlaneDomain::BinanceSmartChainTestnet` not covered
   --> hyperlane-core/src/utils.rs:226:15
    |
226 |           match $v {
    |                 ^^ patterns `chain::KnownHyperlaneDomain::Fuji` and `chain::KnownHyperlaneDomain::BinanceSmartChainTestnet` not covered
```

### Related issues
- Dependency on #3523 
- Fixes #1181 

### Backward compatibility

- [x] Backwards compatible
- [x] Requires docker image tags to be added post-build
- [x] Requires agent artifact cleanup in cloud account:
https://www.notion.so/hyperlanexyz/Runbook-83c755f2652943289cf98cd1309487a8?pvs=4#77730653a12f409dacfbd427cab545d3

### Testing

* Build success
* `yarn hyperlane chains list -e testnet` does not return `mumbai`
* fork.sh script success locally
yorhodes pushed a commit that referenced this pull request Apr 14, 2024
@nbayindirli @yorhodes
add 'mumbai' to chainsToSkip (#3523)
91ea053 
### Description

- Adds `mumbai` to `chainsToSkip` as a preliminary step for deprecating
Polygon Mumbai testnet

### Related Issues

- Unblocks #3521 
- Fixes #1181
yorhodes pushed a commit that referenced this pull request Apr 14, 2024
@nbayindirli @yorhodes
feat: deprecate Mumbai testnet (#3521)
665ebbc 
### Description

- Removes all reference to Mumbai testnet, since it is soon being
[deprecated](https://polygon.technology/blog/polygon-pos-is-cooking-the-napoli-upgrade-means-better-ux-the-mumbai-testnet-takes-a-bow)
by the Polygon team
- Monorepo docker tag:
https://console.cloud.google.com/gcr/images/abacus-labs-dev/global/hyperlane-monorepo@sha256:d4b44359cae9c4e3bdeb6f965c59d056f7fce72c42069adc0dea038ac600785a/details?authuser=5&project=abacus-labs-dev&tab=info
- Agent docker tag:
https://console.cloud.google.com/gcr/images/abacus-labs-dev/global/hyperlane-agent@sha256:a578d96f7f06721d0b6cd8095d6a1fa5d22f01b59eba3320ee3b1fe34ca3c5df/details?authuser=5&project=abacus-labs-dev&tab=info

### Drive-by changes

- Adds missing Testnet domains, Fuji & BSC Testnet
  - Fix for failing `test-rs` CI check with
```
error[E0004]: non-exhaustive patterns: `chain::KnownHyperlaneDomain::Fuji` and `chain::KnownHyperlaneDomain::BinanceSmartChainTestnet` not covered
   --> hyperlane-core/src/utils.rs:226:15
    |
226 |           match $v {
    |                 ^^ patterns `chain::KnownHyperlaneDomain::Fuji` and `chain::KnownHyperlaneDomain::BinanceSmartChainTestnet` not covered
```

### Related issues
- Dependency on #3523 
- Fixes #1181 

### Backward compatibility

- [x] Backwards compatible
- [x] Requires docker image tags to be added post-build
- [x] Requires agent artifact cleanup in cloud account:
https://www.notion.so/hyperlanexyz/Runbook-83c755f2652943289cf98cd1309487a8?pvs=4#77730653a12f409dacfbd427cab545d3

### Testing

* Build success
* `yarn hyperlane chains list -e testnet` does not return `mumbai`
* fork.sh script success locally
letonchanh pushed a commit to letonchanh/hyperlane-monorepo that referenced this pull request Apr 25, 2024
@nbayindirli @letonchanh
feat: deprecate Mumbai testnet (hyperlane-xyz#3521)
9afa2ef 
### Description

- Removes all reference to Mumbai testnet, since it is soon being
[deprecated](https://polygon.technology/blog/polygon-pos-is-cooking-the-napoli-upgrade-means-better-ux-the-mumbai-testnet-takes-a-bow)
by the Polygon team
- Monorepo docker tag:
https://console.cloud.google.com/gcr/images/abacus-labs-dev/global/hyperlane-monorepo@sha256:d4b44359cae9c4e3bdeb6f965c59d056f7fce72c42069adc0dea038ac600785a/details?authuser=5&project=abacus-labs-dev&tab=info
- Agent docker tag:
https://console.cloud.google.com/gcr/images/abacus-labs-dev/global/hyperlane-agent@sha256:a578d96f7f06721d0b6cd8095d6a1fa5d22f01b59eba3320ee3b1fe34ca3c5df/details?authuser=5&project=abacus-labs-dev&tab=info

### Drive-by changes

- Adds missing Testnet domains, Fuji & BSC Testnet
  - Fix for failing `test-rs` CI check with
```
error[E0004]: non-exhaustive patterns: `chain::KnownHyperlaneDomain::Fuji` and `chain::KnownHyperlaneDomain::BinanceSmartChainTestnet` not covered
   --> hyperlane-core/src/utils.rs:226:15
    |
226 |           match $v {
    |                 ^^ patterns `chain::KnownHyperlaneDomain::Fuji` and `chain::KnownHyperlaneDomain::BinanceSmartChainTestnet` not covered
```

### Related issues
- Dependency on hyperlane-xyz#3523 
- Fixes hyperlane-xyz#1181 

### Backward compatibility

- [x] Backwards compatible
- [x] Requires docker image tags to be added post-build
- [x] Requires agent artifact cleanup in cloud account:
https://www.notion.so/hyperlanexyz/Runbook-83c755f2652943289cf98cd1309487a8?pvs=4#77730653a12f409dacfbd427cab545d3

### Testing

* Build success
* `yarn hyperlane chains list -e testnet` does not return `mumbai`
* fork.sh script success locally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorhodes yorhodes yorhodes approved these changes

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@nambrot nambrot Awaiting requested review from nambrot

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More advanced search/filter options (Message Explorer)
2 participants
@nbayindirli @yorhodes