Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix monorepo image building #2988

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Try to fix monorepo image building #2988

merged 4 commits into from
Nov 28, 2023

Conversation

tkporter
Copy link
Collaborator

Description

Drive-by changes

Related issues

Backward compatibility

Testing

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 00dd4af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tkporter tkporter merged commit 66066f9 into v2 Nov 28, 2023
3 checks passed
@tkporter tkporter deleted the trevor/try-fix-img-build branch November 28, 2023 11:34
@tkporter
Copy link
Collaborator Author

Fix for NomicFoundation/hardhat#1925

daniel-savu pushed a commit that referenced this pull request Jun 5, 2024
@tkporter @daniel-savu
Try to fix monorepo image building (#2988)
399d3db 
### Description

<!--
What's included in this PR?
-->

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?

None/Manual/Unit Tests
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

@nambrot nambrot Awaiting requested review from nambrot nambrot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tkporter