Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump @typechain/ethers-v5 to v11 #2910

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

byeongsu-hong
Copy link
Contributor

@byeongsu-hong byeongsu-hong commented Nov 10, 2023

Description

Bump @typechain/ethers-v5 from v10 to v11 - It contains support of const-assertions
This is must-have feature for viem users

Drive-by changes

  • execute yarn up @typechain/ethers-v5

Backward compatibility

Yes

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2910 (71f1e79) into main (f9d67aa) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 71f1e79 differs from pull request most recent head 51c2087. Consider uploading reports for the commit 51c2087 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2910      +/-   ##
==========================================
+ Coverage   68.02%   68.04%   +0.02%     
==========================================
  Files          99       99              
  Lines        1032     1017      -15     
  Branches      107      106       -1     
==========================================
- Hits          702      692      -10     
- Misses        284      286       +2     
+ Partials       46       39       -7     
Components Coverage Δ
core 50.00% <ø> (-6.25%) ⬇️
hooks 71.42% <ø> (+2.63%) ⬆️
isms 71.22% <ø> (+5.28%) ⬆️
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (+1.28%) ⬆️

@yorhodes yorhodes changed the base branch from v3 to main November 21, 2023 15:42
@yorhodes yorhodes enabled auto-merge November 21, 2023 15:44
auto-merge was automatically disabled November 26, 2023 15:42

Head branch was pushed to by a user without write access

Copy link

changeset-bot bot commented Nov 26, 2023

⚠️ No Changeset found

Latest commit: 51c2087

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@avious00
Copy link
Contributor

hey @yorhodes is this pr still relevant?

@byeongsu-hong
Copy link
Contributor Author

byeongsu-hong commented Feb 28, 2024

Hey @yorhodes @avious00, It seems the const-assertion bind already applied in latest version of @hyperlane-xyz/core package, due to Typechain applied const-assertion to v10 at Dec 12 (a month after this PR). So it would be good to know your thoughts on whether this PR merged or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint
Development

Successfully merging this pull request may close these issues.

3 participants