Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify testnet4 deploy #2820

Merged
merged 15 commits into from
Oct 23, 2023
Merged

Verify testnet4 deploy #2820

merged 15 commits into from
Oct 23, 2023

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Oct 18, 2023 •
edited
Loading

Description

  • Adds tooling for flattening source code for use in solidity-single-file verification
  • Recovers all verification artifacts in HyperlaneDeployer from cached addresses

Drive-by changes

  • Adjusts hardhat compiler settings to be pipe through to typechain
  • Removes solana from testnet4
  • Migrate to etherscan family explorer for scrollsepolia

Related issues

Backward compatibility

  • Yes

Testing

  • Verified testnet4 contracts

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #2820 (edff603) into v3 (b71050a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##               v3    #2820   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files         100      100           
  Lines        1007     1007           
  Branches      104      104           
=======================================
  Hits          623      623           
  Misses        347      347           
  Partials       37       37
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 67.93% <ø> (ø)
isms 68.65% <ø> (ø)
token 55.44% <ø> (ø)
middlewares 73.17% <ø> (ø)

@yorhodes yorhodes requested a review from nambrot as a code owner October 18, 2023 18:32
@yorhodes yorhodes requested a review from jmrossy as a code owner October 19, 2023 14:21
@yorhodes yorhodes changed the base branch from v3 to fix-v3-deploy October 19, 2023 14:22
@yorhodes yorhodes changed the title Add script for flattening Verify testnet4 deploy Oct 19, 2023
nambrot
nambrot approved these changes Oct 19, 2023
View reviewed changes
solidity/flatten.sh Show resolved Hide resolved
typescript/sdk/src/deploy/HyperlaneDeployer.ts Outdated Show resolved Hide resolved
Base automatically changed from fix-v3-deploy to v3 October 20, 2023 20:01
@yorhodes yorhodes enabled auto-merge (squash) October 23, 2023 17:10
@yorhodes yorhodes merged commit 8e84ef4 into v3 Oct 23, 2023
19 checks passed
@yorhodes yorhodes deleted the verify-v3 branch October 23, 2023 17:44
@yorhodes yorhodes mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nambrot nambrot nambrot approved these changes

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@aroralanuk aroralanuk Awaiting requested review from aroralanuk aroralanuk is a code owner

@jmrossy jmrossy Awaiting requested review from jmrossy jmrossy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorhodes @nambrot