-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helloworld program and tooling #2744
Conversation
… trevor/helloworld-program
…ll with non-ethereum protocols
… trevor/helloworld-program
… trevor/helloworld-program
… trevor/helloworld-program
… trevor/helloworld-program-and-tooling
… trevor/helloworld-program-and-tooling
… trevor/helloworld-program-and-tooling
… trevor/helloworld-program-and-tooling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting first round of comments as I need to refresh the page due to the new commit :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mostly reviewed the client changes and since it's just scripting I avoided being very nitpicky. I also didn't focus too much on the router / gas filtering logic, let me know if I should ✌️
… trevor/helloworld-program-and-tooling
… trevor/helloworld-program-and-tooling
Description
rust/sealevel/programs/helloworld
--require-tx-approval
to prevent txs from being called without first promptingcore deploy
multisig-ism-message-id configure
, that takes in a JSON file of multisig ISM configs and applies them onchainmailbox receive
RouterApp
contractsMap: HyperlaneContractsMap<Factories>,
, which require attached contracts, a newreadonly foreignDeployments: ChainMap<Address> = {},
is added to the constructorremoteChains(chainName: string)
, but not inchains()
-- this means thatchains()
now concretely means "chains that can be deployed to / interacted with and that there is an entry incontractsMap
for, andremoteChains(chainName: string)
returns any and all remote chains, regardless of whether they can be deployed to / interacted withSome things to note:
Drive-by changes
Related issues
#2502
Backward compatibility
I believe it should all be backward compatible
Testing
Deployed, ran checkers, etc