Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement metadata building for Aggregation ISMs #3451

Closed
3 tasks
Tracked by #3448
tkporter opened this issue Mar 20, 2024 · 0 comments · Fixed by #3701
Closed
3 tasks
Tracked by #3448

Implement metadata building for Aggregation ISMs #3451

tkporter opened this issue Mar 20, 2024 · 0 comments · Fixed by #3701
Assignees
Labels

Comments

@tkporter
Copy link
Collaborator

tkporter commented Mar 20, 2024

Note this should be built out in a protocol agnostic manner, but we expect to only implement chain interactions (view calls, etc) for EVM for now.

In the SDK:

  • Implement a metadata builder for an aggregation ISM. See Rust implementation for inspiration and the Solidity library for Aggregation ISM metadata.
    • Pick threshold metas that we were able to successfully build metadata for. Note that we won't be supporting the building of MerkleRootMultisig ISM metadata (because this requires data that's hard to get for self-relaying), and aggregation ISMs often include these. So we should be tolerant of us not being able to build sub module ISM metadata. In the agents, we have some logic to use the cheapest valid metadatas, but this is 100% optional, imo it's fine here to just arbitrarily pick the threshold sub modules that we were able to successfully build metadata for
    • Similar to Implement metadata building for Routing ISMs #3450, we'll need to make sure that we don't recurse infinitely, e.g. that imagine someone configuring an aggregation ISM that points to itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants