Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge upstream gas escalator and run test #14

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

daniel-savu
Copy link

Fixes some issues @tkporter brought up in hyperlane-xyz/hyperlane-monorepo#3852 (review):

  1. Holding mutex lock across gas escalations (fixed upstream, I just merged the changes)
  2. Silently ignoring nonce related errors: added a warn log. These error are only expected to occur if the original tx landed onchain though
  3. I ran the unit test that comes with this middleware, and similar to what Trevor pointed out, sending a tx returns a PendingTransaction whose tx hash will not reflect the hash of the tx that lands onchain. However I manually checked by polling anvil and emitting logs that the gas is escalated and the final tx is finalized

@daniel-savu daniel-savu merged commit 86d61d6 into hyperlane Jun 27, 2024
0 of 10 checks passed
@daniel-savu daniel-savu deleted the dan/gas-escalator-upstream-merge branch June 27, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants