-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native fetch): Implement Node.js fetch #1243
feat(native fetch): Implement Node.js fetch #1243
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
==========================================
- Coverage 63.52% 63.25% -0.27%
==========================================
Files 111 111
Lines 3304 3326 +22
Branches 567 574 +7
==========================================
+ Hits 2099 2104 +5
- Misses 1016 1032 +16
- Partials 189 190 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all running here! Nice work @syamsudotdev
🍺 🍻 🥂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Monika Pull Request (PR)
This PR resolves #1241
What feature/issue does this PR add
--native-fetch
How did you implement / how did you fix it
--experimental-fetch
to--native-fetch
--native-fetch
AxiosRequestHeaders
to be compatible with plain TypeScript / fetchAxiosRequestConfig
to be compatible with plain TypeScript / fetchtype HttpRequestParams
How to test
npm run start -- --native-fetch --verbose
Probing URL with Node.js fetch