feat(tonic): implement From<Code> for i32
#559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Code` is already trivial to convert into an `i32` however that isn't immediately obvious by looking at the docs. This has tripped me up before. Implementing `From<Code>` for `i32` should hopefully make it a bit more obvious.
davidpdrsn
changed the title
From<Code> for i32From<Code> for i32
LucioFranco
approved these changes
May 12, 2021
|
This doesn't seem like a chore? maybe feat? |
davidpdrsn
changed the title
From<Code> for i32From<Code> for i32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codeis already trivial to convert into ani32however that isn'timmediately obvious by looking at the docs. This has tripped me up
before.
Implementing
From<Code>fori32should hopefully make it a bit moreobvious.