Fix helloworld tutorial. #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
reviewed
Jan 27, 2021
examples/helloworld-tutorial.md
Outdated
| @@ -179,7 +179,7 @@ impl Greeter for MyGreeter { | |||
| Finally, let's define the Tokio runtime that our server will actually run on. This requires Tokio to be added as a dependency, so make sure you included that! | |||
|
|
|||
| ```rust | |||
| #[tokio::main] | |||
| #[tokio::main(flavor = "current_thread")] | |||
There was a problem hiding this comment.
It would probably better to use the multithreaded runtime by adding the feature and removing these flavor changes.
examples/helloworld-tutorial.md
Outdated
| @@ -115,7 +115,7 @@ path = "src/client.rs" | |||
| [dependencies] | |||
| tonic = "0.4" | |||
| prost = "0.7" | |||
| tokio = { version = "0.2", features = ["macros"] } | |||
| tokio = { version = "1.0", features = ["macros"] } | |||
There was a problem hiding this comment.
Suggested change
| tokio = { version = "1.0", features = ["macros"] } | |
| tokio = { version = "1.0", features = ["macros", "rt-multi-thread"] } |
updated tutorial to use tokio 1.x.
16yuki0702
force-pushed
the
fix_helloworld_tutorial
branch
from
f7a10c4
to
bd59497
Compare
|
@olix0r Thank for review! |
LucioFranco
approved these changes
Feb 2, 2021
This was referenced Mar 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I got a error when trying to run helloworld tutorial
because tonic 0.4 currently depends on Tokio 1.x.
Solution
updated example to use Tokio 1.x.