Allow non_camel_case_types on some codegen structs #296
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
approved these changes
Mar 19, 2020
|
The CI failures here are unrelated to this change, but do look valid - I'll take a look at fixing them up on a separate PR and rebasing this on top to get a green run before merge. |
|
@jen20 that would be great, looks like 1.42's deprecation of the old error trait methods. It would be good to fix that thanks 👍 |
This commit adjusts the code generation for the internal structs in the implementation of Service<http::Request<HyperBody>> for *Server<T> in order to annotate internal structs whose names are derived from gRPC method names with `[allow(non_camel_case_types)]`. This supresses compiler warnings about type names when compiling generated code. The struct names are not exposed externally, so this has no impact on types seen by library consumers. Fixes #295.
jen20
force-pushed
the
jen20/allow-non-camel-case-internal-structs
branch
from
79c248a
to
c594514
Compare
|
Rebased on top of master now it has the deprecated error trait method handled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts the code generation for the internal structs in the implementation of
Service<http::Request<HyperBody>>for*Server<T>in order to annotate internal structs whose names are derived from gRPC method names with[allow(non_camel_case_types)]. This supresses compiler warnings about type names when compiling generated code. The struct names are not exposed externally, so this has no impact on types seen by library consumers.Fixes #295.