Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial cut of RouterService #272

Closed
wants to merge 1 commit into from

Conversation

cthulhua
Copy link
Contributor

Motivation

Solution

@LucioFranco
Copy link
Member

This looks pretty good! I think we should just expose it and I think that should work!

@alce
Copy link
Collaborator

alce commented Apr 10, 2020

Hi, this looks very useful.

Unless I'm mistaken, could we add something like this to the Router's impl instead of the service free function and it should be good to go?

    pub fn into_service(self) -> RouterService<A, B> {
        RouterService { router: self }
    }

@a1ph
Copy link

a1ph commented Aug 26, 2020

Should it be closed as #419 is merged.

@cthulhua cthulhua closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants