Expose Response#into_parts and Response#from_parts
#1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parts and into_parts pair.
LucioFranco
requested changes
Feb 13, 2023
LucioFranco
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In cases when you have to build for example an L7 gRPC proxy with data injection into responses from downstream API it's required to perform copying the whole responses to shift ownership this can be easily avoided by implementing the approach suggested for Request in PR: #1118
Solution
This PR contains two changes:
One is to expose
Response#into_partsto easily control the ownership without making unnecessary copying.Another one is to expose
Response#from_parts, in order to have a symmetric API, consistent withRequestas well