Misc client fixes #933
Merged
Misc client fixes #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the connection would be kept alive if there was a connect error. Now it's closed immediately.
It's possible that a connection will be closed and the only way to find out is by doing a read. The keep-alive state (State::Init + Next_::Wait) now tries to read on readable. In the case of EOF, it returns state closed. If bytes are actually available, it's a connection error, and the connection is closed. Otherwise, it's just a spurious wakeup.
The previous keep-alive strategy was to cycle connections in a round-robin style. However, that will always keep more connections around than are needed. This new strategy will allow extra connections to expire when only a few are needed. This is accomplished by prefering to reuse a connection that was just released to the pool over one that has been there for a long time.
We encountered some issues where the `Conn::ready()` would busy loop on reads. Previously, the `ConnInner::can_read_more()` would not consider whether the previous read got a WouldBlock error, and it didn't consider whether the transport was blocked. Accounting for this additional state fixes the busy loop problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes improvements to client error handling, keep-alive strategy, and fixes a busy-loop. Sorry for putting these all in one PR, but they build on each other and it's still relatively short. Probably makes sense to review commit at a time.