Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server keep alive to send more than one ping #2315

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Fix server keep alive to send more than one ping #2315

merged 2 commits into from
Oct 29, 2020

Commits on Oct 29, 2020

  1. test(server): test server keep alive by counting number of pings 

    Add `http2_keep_alive_count_server_pings` which tests if 3 pings are
received under 5 seconds with keep alive interval set to 1 second.
    @pdcalado
    pdcalado committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    15c52d3 View commit details
    Browse the repository at this point in the history

  2. fix(server): reschedule keep alive interval timer once a pong is rece… 

    …ived

`KeepAliveState` did not transition from `PingSent` to `Scheduled` after
a pong was received. This prevented more than one ping to be sent by the
server. This fix checks if `ping_sent_at` has already been cleared by
`Ponger::poll` when `KeepAliveState::PingSent` state is active.

Fixes hyperium#2310
    @pdcalado
    pdcalado committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    a15d27e View commit details
    Browse the repository at this point in the history