Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): add fix for keep-alive connection on http version 1.0 #1634

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

lambdasqd
Copy link
Contributor

Change behaviour of connection or server response when the request is
version 1.0 and the Connection: keep-alive header is not present.

  1. If the response is also version 1.0, then connection is closed if the
    server keep-alive header is not present.
  2. If the response is version 1.1, then the keep-alive header is added
    when downgrading to version 1.0.

CLOSES: #1614

Change behaviour of connection or server response when the request is
version 1.0 and the Connection: keep-alive header is not present.

1. If the response is also version 1.0, then connection is closed if the
server keep-alive header is not present.
2. If the response is version 1.1, then the keep-alive header is added
when downgrading to version 1.0.

CLOSES: hyperium#1614
@seanmonstar seanmonstar merged commit 1448e40 into hyperium:master Aug 15, 2018
@seanmonstar
Copy link
Member

Awesome PR, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP/1.0 and keep-alive bug
2 participants