Fix example & cherry-pick server::conn::Parts.service to master #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows getting the original service back. Closes hyperium#1471 Cherry-pick of commit bf7c0bb from the 0.11.x branch.
|
Oh wow, thanks for noticing this! It definitely was just forgotten, and it would have been unfortunate, cause bringing it back would have been a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes
cargo testfor me.The second commit
backportsforwardports the fix to issue #1471 to master. Hopefully it was just forgotten and not omitted intentionally, because otherwise implementing server upgrades is more difficult.