Refactor HTTP upgrades into Extensions #2340
Labels
A-http1
Area: HTTP/1 specific.
C-refactor
Category: refactor. This would improve the clarity of internal code.
E-medium
Effort: medium. Some knowledge of how hyper internal works would be useful.
Comments
seanmonstar
added
E-medium
|
I'd like to try solving this if it's OK? I started a draft PR #2353, but could use some guidance as I'm unsure about a few things (some basic Rust things, and how to get state into the extensions of Requests and Responses f.ex.). I'm interested in learning to contribute to hyper, and this looks like it could be a place to start :) |
aknuds1
added a commit
to aknuds1/hyper
that referenced
this issue
Dec 13, 2020
Move state required for protocol upgrades to head representations, instead of associating it with the body. Closes hyperium#2340. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
added a commit
to aknuds1/hyper
that referenced
this issue
Dec 13, 2020
Move state required for protocol upgrades to head representations, instead of associating it with the body. Closes hyperium#2340. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
added a commit
to aknuds1/hyper
that referenced
this issue
Dec 13, 2020
Move state required for protocol upgrades to head representations, instead of associating it with the body. Closes hyperium#2340. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
added a commit
to aknuds1/hyper
that referenced
this issue
Dec 13, 2020
Move state required for protocol upgrades to head representations, instead of associating it with the body. Closes hyperium#2340. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
added a commit
to aknuds1/hyper
that referenced
this issue
Dec 15, 2020
Move state required for protocol upgrades to head representations, instead of associating it with the body. Closes hyperium#2340. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
added a commit
to aknuds1/hyper
that referenced
this issue
Dec 15, 2020
Move state required for protocol upgrades to head representations, instead of associating it with the body. Closes hyperium#2340. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
seanmonstar
pushed a commit
that referenced
this issue
Dec 15, 2020
Move state required for protocol upgrades to head representations, instead of associating it with the body. Closes #2340. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
BenxiangGe
pushed a commit
to BenxiangGe/hyper
that referenced
this issue
Jul 26, 2021
Move state required for protocol upgrades to head representations, instead of associating it with the body. Closes hyperium#2340. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #2086, it was outlined how the HTTP upgrades should be moved off the
Bodytype (and intoExtensions). The public facing part was done, now we just need to update the internalproto::h1stuff to stash them into theExtensionsinstead of on a privateBodyfield.In order to do so, the
proto::MessageHeadwill need to gain anextensionsfield, so we can place them there.The text was updated successfully, but these errors were encountered: