Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to set sleep_on_errors for server Builder #1713

Closed
sanmai-NL opened this issue Nov 17, 2018 · 4 comments
Closed

Add a way to set sleep_on_errors for server Builder #1713

sanmai-NL opened this issue Nov 17, 2018 · 4 comments
Labels
A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@sanmai-NL
Copy link
Contributor

Currently in Hyper server 0.12.14, sleep_on_errors can be set via server::conn::AddrIncoming. When using server::Builder, however, other parameters (e.g., tcp_nodelay) can be set, but sleep_on_errors can’t.
@sanmai-NL
Copy link
Contributor Author

See also #1712.

@seanmonstar
Copy link
Member

It seems like we could add a tcp_sleep_on_errors(bool) method to Builder<AddrIncoming, E>.

@seanmonstar seanmonstar added A-server Area: server. E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. labels Nov 22, 2018
@seanmonstar seanmonstar changed the title Too limited API to set sleep_on_errors Add a way to set sleep_on_errors for server Builder Nov 22, 2018
@starsheriff
Copy link
Contributor

Hei, I was looking for an easy task to start contributing to the world of rust. Could I give that one a shot or is anyone already working on it?

@seanmonstar
Copy link
Member

@starsheriff Have at it!

starsheriff added a commit to starsheriff/hyper that referenced this issue Nov 27, 2018
@starsheriff
feat(server): add sleep_on_errors builder method
85333ee 
This method allows to set the value of the `sleep_on_errors` option for
accepted connections using the builder.

Closes hyperium#1713
starsheriff added a commit to starsheriff/hyper that referenced this issue Nov 27, 2018
@starsheriff
feat(server): add tcp_sleep_on_accept_errors builder method
a562c7b 
This method allows to set the value of the `sleep_on_errors` option for
accepted connections using the builder.

Closes hyperium#1713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seanmonstar @sanmai-NL @starsheriff