fix(http): skip zero length chunks when encoding

hyperium · Jul 17, 2017 · d6da3f7 · d6da3f7
1 parent 85c6bec
commit d6da3f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/http/conn.rs b/src/http/conn.rs
@@ -269,6 +269,10 @@ where I: AsyncRead + AsyncWrite,
                     return Ok(AsyncSink::NotReady(chunk));
                 }
                 if let Some(chunk) = chunk {
+                    if chunk.as_ref().is_empty() {
+                        return Ok(AsyncSink::Ready);
+                    }
+
                     let mut cursor = Cursor::new(chunk);
                     match encoder.encode(&mut self.io, cursor.buf()) {
                         Ok(n) => {

diff --git a/src/http/h1/encode.rs b/src/http/h1/encode.rs
@@ -63,7 +63,7 @@ impl Encoder {
                 };
 
                 if n == 0 {
-                    return Err(io::Error::new(io::ErrorKind::WouldBlock, "would block"));
+                    return Err(io::Error::new(io::ErrorKind::WriteZero, "write zero"));
                 }
 
                 *remaining -= n as u64;