New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate path bytes are at least utf8 #756

Merged

seanmonstar merged 1 commit into master from uri-check-utf8

Mar 11, 2025

Member

seanmonstar commented Mar 11, 2025


          fix: validate path bytes are at least utf8

b9603ea

GlenDC approved these changes

View reviewed changes

joelwurtz approved these changes

View reviewed changes

joelwurtz reviewed

View reviewed changes

src/uri/path.rs

+                                  // potentially utf8, might not, should check
+x7F..=0xFF => {
+                                      is_maybe_not_utf8 = true;

Contributor

joelwurtz Mar 11, 2025

nice idea to avoid checking utf8 in most case, maybe we could do something similar in http-parse, will look at it (since utf8 is not common in path)

seanmonstar merged commit 6637a72 into master

10 checks passed

seanmonstar deleted the uri-check-utf8 branch

March 11, 2025 20:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet