Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose poll_recv_trailers APIs #269

Merged
merged 5 commits into from
Dec 29, 2024

Conversation

youyuanwu
Copy link
Contributor

@youyuanwu youyuanwu commented Dec 17, 2024

Expose poll style APIs for receive trailers (and data).
I need these APIs to imbed the h3 connection into http body and implement the poll_frame. With this change I can successfully send and receive http::Request body with streaming.

This also matches the h2 poll_trailers api:
https://github.com/hyperium/h2/blob/3bce93e9b0dad742ffbf62d25f9607ef7651a70c/src/share.rs#L427

Copy link
Contributor

@Ruben2424 Ruben2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left some thoughts below.

h3/src/connection.rs Outdated Show resolved Hide resolved
h3/src/client/stream.rs Show resolved Hide resolved
Copy link
Contributor

@Ruben2424 Ruben2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ruben2424 Ruben2424 merged commit d47e24a into hyperium:master Dec 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants