ensure LICENSE file is present in all published crates #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds symbolic links for the
LICENSEfile into theh3andh3-quinnworkspace members so thatcargo package/cargo publishpicks them up and includes them when publishing crates.The MIT license requires that (re)distributed sources contain a copy of the license text. Not including the license text is a problem, especially for Linux distributions that package this crate as a dependency, for example, for the HTTP/3 support in the
reqwestcrate.I have not added a symlink into the
h3-webtransportdirectory since this workspace member is not published to crates.io, and does even not have complete cargo metadata yet.