simplify traits #599

Sign in to view logs

Triggered via pull request March 13, 2024 21:21

Ruben2424

synchronize #200

Ruben2424:simplify-traits

Status Failure

Total duration 49s

Artifacts –

CI.yml

on: pull_request

Matrix: test

Check MSRV of `h3-quinn`

Compliance report

Annotations

11 errors and 22 warnings

Check Style

The process '/home/runner/.cargo/bin/cargo' failed with exit code 1

Lint: h3-webtransport/src/stream.rs#L30

type `Error` is not a member of trait `quic::RecvStream`

Lint: h3-webtransport/src/stream.rs#L118

type `Error` is not a member of trait `quic::SendStream`

Lint: h3-webtransport/src/stream.rs#L223

type `Error` is not a member of trait `quic::SendStream`

Lint: h3-webtransport/src/stream.rs#L263

type `Error` is not a member of trait `quic::RecvStream`

Lint: h3-webtransport/src/stream.rs#L35

associated type `Error` not found for `Self`

Lint: h3-webtransport/src/stream.rs#L108

associated type `Error` not found for `Self`

Lint: h3-webtransport/src/stream.rs#L118

associated type `Error` not found for `S`

Lint: h3-webtransport/src/stream.rs#L120

associated type `Error` not found for `Self`

Lint: h3-webtransport/src/stream.rs#L132

associated type `Error` not found for `Self`

Lint: h3-webtransport/src/stream.rs#L136

associated type `Error` not found for `Self`

Check Style

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Check Style

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Check Style

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check Style

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check Style

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check Style

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`

Lint: h3/src/stream.rs#L3

unused import: `pin::Pin`

Lint: h3/src/stream.rs#L10

unused import: `tokio::io::ReadBuf`

Lint: h3/src/qpack/mod.rs#L3

unused imports: `Decoder`, `Encoder`, `ack_header`, `dynamic::Error as DynamicTableError`, `stream_canceled`

Lint: h3/src/qpack/prefix_string/mod.rs#L14

unused import: `DecodeIter`

Lint: h3/src/qpack/stream.rs#L102

unused variable: `e`

Lint: h3/src/quic.rs#L84

match expression looks like `matches!` macro

Lint: h3/src/quic.rs#L181

very complex type used. Consider factoring parts into `type` definitions

Lint: h3/src/server.rs#L396

returning the result of a `let` binding from a block

Lint: h3/src/qpack/stream.rs#L297

casting to the same type is unnecessary (`u64` -> `u64`)