Replace futures-util with atomic-waker and manual poll_fn #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes ones of the heavier dependencies. The goal is to also remove futures-util from the rest of the dependency tree, which is hard to justify when futures-util is used in more fundamental dependencies. Signed-off-by: John Nunley <dev@notgull.net>
|
@seanmonstar Any chance you can review this? |
|
Sorry, yes I will take a look, but I want to check out this separate dependency, and just didn't have time while trying to cram all the prep work to release hyper 1.0 (today). |
GlenDC
approved these changes
Nov 23, 2023
jplatte
approved these changes
Dec 30, 2023
|
@seanmonstar Has |
mladedav
approved these changes
Feb 9, 2024
dswij
approved these changes
Mar 7, 2024
|
@seanmonstar Just following up on this. Have you had to chance to consider this yet? |
seanmonstar
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes ones of the heavier dependencies. The goal is to also remove
futures-util from the rest of the dependency tree, which is hard to justify when
futures-util is used in more fundamental dependencies.
Closes #507
Signed-off-by: John Nunley dev@notgull.net