add Connection::max_concurrent_recv_streams
#516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
approved these changes
Feb 18, 2021
| /// [`SETTINGS_MAX_CONCURRENT_STREAMS` parameter][settings] in a `SETTINGS` | ||
| /// frame. This method returns the currently acknowledged value recieved | ||
| /// from the remote. | ||
| /// [`SETTINGS_MAX_CONCURRENT_STREAMS` parameter][1] in a `SETTINGS` frame. |
There was a problem hiding this comment.
I think this [1] change is half-way. The [settings]: .... below needs to be updated as well.
There was a problem hiding this comment.
oh whoops --- good catch!
hawkw
commented
Feb 18, 2021
This commit adds accessors to `client::Connection` and `server::Connection` that return the current value of the `SETTINGS_MAX_CONCURRENT_STREAMS` limit that has been sent by this peer and acknowledged by the remote. This is analogous to the `max_concurrent_send_streams` methods added in PR #513. These accessors may be somewhat less useful than the ones for the values negotiated by the remote, since users who care about this limit are probably setting the builder parameter. However, it seems worth having for completeness sake --- and it might be useful for determining whether or not a configured concurrency limit has been acked yet... Part of #512
hawkw
force-pushed
the
eliza/expose-recv-streams
branch
from
ab19270 to
b91d5d5
Compare
hawkw
added a commit
to hawkw/hyper
that referenced
this pull request
Mar 10, 2021
Upstream PRs hyperium/h2#513 and hyperium/h2#516 added functions for exposing the connection concurrency limits negotiated by a remote peer. Recording these settings can be useful for debugging purposes. In the higher-level `Client` and `Server` APIs, it's not easily possible to provide a way for users to directly access settings on a particular connection, since the client abstracts over a connection pool and the server abstracts over a connect loop. Therefore, the user can't access these settings directly. Instead, this branch adds new log messages at the DEBUG level for recording negotiated concurrency limits. In a follow-up, we can also add accessors to the `Connection` types in the lower-level `client::conn` and `server::conn` APIs.
hawkw
added a commit
to hawkw/hyper
that referenced
this pull request
Mar 10, 2021
Upstream PRs hyperium/h2#513 and hyperium/h2#516 added functions for exposing the connection concurrency limits negotiated by a remote peer. Recording these settings can be useful for debugging purposes. In the higher-level `Client` and `Server` APIs, it's not easily possible to provide a way for users to directly access settings on a particular connection, since the client abstracts over a connection pool and the server abstracts over a connect loop. Therefore, the user can't access these settings directly. Instead, this branch adds new log messages at the DEBUG level for recording negotiated concurrency limits. In a follow-up, we can also add accessors to the `Connection` types in the lower-level `client::conn` and `server::conn` APIs.
BenxiangGe
pushed a commit
to BenxiangGe/h2
that referenced
this pull request
Jul 26, 2021
This commit adds accessors to `client::Connection` and `server::Connection` that return the current value of the `SETTINGS_MAX_CONCURRENT_STREAMS` limit that has been sent by this peer and acknowledged by the remote. This is analogous to the `max_concurrent_send_streams` methods added in PR hyperium#513. These accessors may be somewhat less useful than the ones for the values negotiated by the remote, since users who care about this limit are probably setting the builder parameter. However, it seems worth having for completeness sake --- and it might be useful for determining whether or not a configured concurrency limit has been acked yet... Part of hyperium#512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds accessors to
client::Connectionandserver::Connectionthat return the current value of theSETTINGS_MAX_CONCURRENT_STREAMSlimit that has been sent by this peerand acknowledged by the remote.
This is analogous to the
max_concurrent_send_streamsmethods added inPR #513. These accessors may be somewhat less useful than the ones for
the values negotiated by the remote, since users who care about this
limit are probably setting the builder parameter. However, it seems
worth having for completeness sake --- and it might be useful for
determining whether or not a configured concurrency limit has been acked
yet...
Part of #512