Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Flex attributes #7

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Added Flex attributes #7

merged 2 commits into from
Jan 29, 2024

Conversation

MiskaVivolin
Copy link
Contributor

No description provided.

thejhh
thejhh requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@thejhh thejhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, few changes requested

entities/style/StyleEntity.ts Outdated Show resolved Hide resolved
entities/types/Display.ts Outdated Show resolved Hide resolved
@MiskaVivolin
Copy link
Contributor Author

resolved requests

thejhh
thejhh approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@thejhh thejhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MiskaVivolin MiskaVivolin merged commit 227017f into main Jan 29, 2024
1 check failed
@MiskaVivolin MiskaVivolin deleted the miskadev branch January 29, 2024 11:06
This was referenced Apr 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejhh thejhh thejhh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiskaVivolin @thejhh