Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-static controllers not supported #4

Closed
Tracked by #13
thejhh opened this issue Jan 20, 2024 · 0 comments
Closed
Tracked by #13

Non-static controllers not supported #4

thejhh opened this issue Jan 20, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@thejhh
Copy link
Contributor

thejhh commented Jan 20, 2024

Issue Summary

This issue fixes the lack of support for non-static methods in a controller handling an HTTP request. The resolution for this issue can be found in the branch named feature/fix-non-static-controller-methods.

Steps to Reproduce

  1. Create a Method: Implement a non-static method in a controller to handle a specific endpoint.
  2. Bind Instance: Associate the instance of the controller with the request server.
  3. Initiate Request: Execute a request targeting the endpoint.

Expected Behavior

The instance method should be invoked successfully, handling the request without any issues.

Actual Behavior

The request leads to a 404 error. The logs display a warning from [RequestRouterImpl] stating: Warning! No property by name '...' found in the controller.

@thejhh thejhh added the bug Something isn't working label Jan 20, 2024
@thejhh thejhh self-assigned this Jan 20, 2024
thejhh pushed a commit that referenced this issue Jan 20, 2024
@thejhh thejhh closed this as completed Jan 23, 2024
This was referenced Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant