Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check consul service once #325

Merged
merged 4 commits into from
Aug 3, 2019
Merged

check consul service once #325

merged 4 commits into from
Aug 3, 2019

Conversation

wenbinye
Copy link
Contributor

@wenbinye wenbinye commented Aug 2, 2019

现在每个 rpc 方法都会导致一次 consul services 接口查询调用，如果 rpc 方法很多，比较耗时

@huangzhhui
Copy link
Member

这样的话服务失效了怎么办呢？

@wenbinye
Copy link
Contributor Author

wenbinye commented Aug 2, 2019

这个缓存不是长期的，process 函数每次调用都会重置。

@limingxinleo limingxinleo requested review from huangzhhui and limingxinleo and removed request for huangzhhui August 3, 2019 05:33
limingxinleo
limingxinleo approved these changes Aug 3, 2019
View reviewed changes
Copy link
Member

@limingxinleo limingxinleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huangzhhui 我觉得 OK 的，你抽空再看一眼

@huangzhhui huangzhhui merged commit 5c4c1d9 into hyperf:master Aug 3, 2019
@wenbinye wenbinye deleted the feature-add-service-govenance-test branch August 3, 2019 07:32
@huangzhhui
Copy link
Member

@wenbinye 你的 Git 客户端的邮箱和姓名配置应该有问题，在项目的 Commit 记录里 Github 识别不到你

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangzhhui huangzhhui huangzhhui approved these changes

@limingxinleo limingxinleo limingxinleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenbinye @huangzhhui @limingxinleo