Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: GitHub Actions test and build #294

Merged
merged 6 commits into from
Oct 27, 2020

Conversation

jbolda
Copy link
Contributor

@jbolda jbolda commented Apr 16, 2020

BACKGROUND:

  • What led to this work, and what is the broader context of this change?
    Trying to help out! 👍

DESCRIPTION:

  • What does this PR specifically accomplish?
    Supplementing Travis CI (and maybe eventually replacing?).

TESTING:

  • How should a reviewer observe the behavior desired by this pull request?
    The checks below on pull request and in the Actions tab on pushes to master.

FUTURE WORK:

  • Is there any future work needed or anticipated? Does this PR create any obvious technical debt?
    We have been discussing add package publishing to this pipeline, but more needs to be decided and hashed out before that happens.

COMMENTS:


This change is Reviewable

@jbolda
Copy link
Contributor Author

jbolda commented Apr 16, 2020

Note that you will likely need to turn on Github Actions in the settings to see the build.

@ikeough
Copy link
Contributor

ikeough commented Apr 17, 2020

Thanks very much for this @jbolda! We're getting a bunch of other PRs in for the 0.7.0 release currently, but I will review as soon as that is done.

@ikeough ikeough added this to the 0.8.0 milestone Oct 27, 2020
@ikeough ikeough self-assigned this Oct 27, 2020
@ikeough ikeough added the Enhancement New feature or request label Oct 27, 2020
Copy link
Contributor

@ikeough ikeough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ikeough)

@ikeough ikeough merged commit 94381f5 into hypar-io:master Oct 27, 2020
@ikeough
Copy link
Contributor

ikeough commented Oct 27, 2020

@jbolda Better late than never. We've actually moved on to support .net core 3.1. so we'll have to update from this side. Thanks very much for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants