Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementInstance constructor should be internal. #271

Closed
ikeough opened this issue Mar 18, 2020 · 0 comments
Closed

ElementInstance constructor should be internal. #271

ikeough opened this issue Mar 18, 2020 · 0 comments
Assignees
@andrewheumann
Labels
Bug Something isn't working
Milestone
0.7

Comments

@ikeough
Copy link
Contributor

ikeough commented Mar 18, 2020 •
edited
Loading

Currently the constructor to ElementInstance is public, which allows a developer to create an instance of this type, passing in a GeometricElement instance which has not been properly flagged as IsElementDefinition. This means that instances of GeometricElement which are meant to be base definitions will show up in the scene because the IsElementDefintion flag is not set.
@ikeough ikeough added the Bug Something isn't working label Mar 18, 2020
@ikeough ikeough added this to the 0.7 milestone Mar 18, 2020
ikeough added a commit that referenced this issue Apr 14, 2020
@ikeough
Merge pull request #282 from ikeough/fix-271
d448e6b 
Fix #271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewheumann andrewheumann

Labels
Bug Something isn't working
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
2 participants
@ikeough @andrewheumann