Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Navigate to [ImageSlider] with shared element #554

Merged
merged 3 commits into from
May 24, 2022

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented May 24, 2022

Specify project

client

Description

Navigate to [ImageSlider] with shared element for smooth transition.

Related Issues

N/A

Tests

Mocked react-navigation-shared-element.
Update snapshot.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update the snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan added 🍗 enhancement New feature or request 📱 client labels May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #554 (47f9f86) into main (b6c829c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   72.30%   72.30%           
=======================================
  Files          65       65           
  Lines        1307     1307           
  Branches      160      160           
=======================================
  Hits          945      945           
  Misses        335      335           
  Partials       27       27           
Flag Coverage Δ
unittests 72.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deae9e9...47f9f86. Read the comment docs.

@hyochan hyochan merged commit 9d73f0c into main May 24, 2022
@hyochan hyochan deleted the feat/image-shared-element branch May 24, 2022 08:19
@hyochan
Copy link
Owner Author

hyochan commented May 24, 2022

Simulator.Screen.Recording.-.iPhone.13.-.2022-05-24.at.17.03.58.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📱 client 🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant