Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Migrate client to expo sdk 43 #508

Merged
merged 3 commits into from
Oct 24, 2021
Merged

Migrate client to expo sdk 43 #508

merged 3 commits into from
Oct 24, 2021

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Oct 24, 2021

Specify project

Client

Description

Migrate client to expo SDK 43.

See the release note if you are interested.

Related Issues

N/A

Tests

Since @dooboo-ui/theme package is now enforcing useTheme to be wrapped with ThemeProvider, I've wrapped all test elements with ThemeProvider before rendering.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan added 🗃 update packages 🚽 migration Activities due to changes in framework labels Oct 24, 2021
@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #508 (94a912c) into master (4f67f05) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   76.09%   76.09%           
=======================================
  Files          64       64           
  Lines        1163     1163           
  Branches      130      130           
=======================================
  Hits          885      885           
  Misses        276      276           
  Partials        2        2           
Flag Coverage Δ
unittests 76.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f67f05...94a912c. Read the comment docs.

@hyochan hyochan merged commit ed6c2b5 into master Oct 24, 2021
@hyochan hyochan deleted the migration/expo-sdk-43 branch October 24, 2021 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚽 migration Activities due to changes in framework 🗃 update packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant