Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: re-configure storybook hosting for web #537

Merged
merged 13 commits into from
Feb 7, 2024

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Feb 7, 2024

Description

screen

Delete the separately documented Storybook from the past, and change the structure to manage it together with the existing root project.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan marked this pull request as ready for review February 7, 2024 16:48
@hyochan hyochan added the 💨 ci Cloud integration label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #537 (81b116e) into main (c8e69bd) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   75.31%   75.23%   -0.08%     
==========================================
  Files          36       36              
  Lines         948      945       -3     
  Branches      434      435       +1     
==========================================
- Hits          714      711       -3     
  Misses        229      229              
  Partials        5        5              

Copy link

github-actions bot commented Feb 7, 2024

Visit the preview URL for this PR (updated for commit 81b116e):

https://dooboo-ui--pr537-migration-storybook-tf6kh5t2.web.app

(expires Wed, 14 Feb 2024 19:40:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a0e10c9c53f1ddcb575fbed95c0d86c6668ad0f0

@hyochan hyochan merged commit 061c0b1 into main Feb 7, 2024
5 checks passed
@hyochan hyochan deleted the migration/storybook-web branch February 7, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant