Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limitations of border calculation in [ButtonGroup] #78

Closed
yujonglee opened this issue Aug 22, 2021 · 3 comments
Closed

Limitations of border calculation in [ButtonGroup] #78

yujonglee opened this issue Aug 22, 2021 · 3 comments
Assignees
@yujonglee
Labels
1️⃣ good first issue Good for newcomers

Comments

@yujonglee
Copy link
Contributor

Currently, ButtonGroup's default flex-direction is row. And border calculation is done base on it.

But, If I change it to column, It breaks.

스크린샷 2021-08-22 오후 8 46 44
스크린샷 2021-08-22 오후 8 46 30

Possible Solution: Enhance border calculation logic.
@yujonglee
Copy link
Contributor Author

yujonglee commented Aug 22, 2021 •
edited
Loading

I've done several works on ButtonGroup, (#53, #56, #62 ) so I'm planning to work on this too.

@hyochan hyochan added the 1️⃣ good first issue Good for newcomers label Aug 22, 2021
@hyochan
Copy link
Owner

hyochan commented Aug 22, 2021

It's great for testing out. However, I am still curious if there is a use-case on [ButtonGroup] to be used as a column.
This [ButtonGroup] component is inspired by the SegmentedControl in Cupertino design system.

Do you still think we need column? Or there might be a better idea on improving it like SegmentedControl 🤔

@yujonglee yujonglee mentioned this issue Sep 1, 2021
Closed
@yujonglee
Copy link
Contributor Author

Will be re-opened if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yujonglee yujonglee

Labels
1️⃣ good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hyochan @yujonglee