Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Implement tab components #95

Closed
devdubby opened this issue Sep 1, 2021 · 5 comments
Closed

[Tabs] Implement tab components #95

devdubby opened this issue Sep 1, 2021 · 5 comments
Labels
💬 discussion Discuss issues

Comments

@devdubby
Copy link
Contributor

devdubby commented Sep 1, 2021

Material Design Tabs Component
Tabs components are commonly used. It will be useful for rendering other screens when selecting tabs.

스크린샷 2021-09-01 오후 8 43 49

I think it would be good to develop it so that we can set the number of tabs. I think it would be good to make a component with default tabs.

@devdubby
Copy link
Contributor Author

devdubby commented Sep 1, 2021

Is it okay to implement this? In that case, please assign it to me.

@yujonglee
Copy link
Contributor

@devdubby I think it is similar to ButtonGroup in dobooo-ui. If you have some ideas which can't be done with ButtonGroup, I think you can start working on new component or enhance existing ButtonGroup.

See this might be helpful too.

@devdubby
Copy link
Contributor Author

devdubby commented Sep 1, 2021

@yujong-lee Oh, it's similar to Button Group. Then we'll have to work on improving ButtonGroup. For example, would you like me to put the underline under the activated button? I'll look for better improvements.

@hyochan
Copy link
Owner

hyochan commented Sep 1, 2021

Actually, ButtonGroup is similar to segmented control in iOS and this one is a material top tab in android.

This implementation is already done in react-navigation material top tap so I think it is not needed in the community!

@devdubby However, if you think you want to have a challenge, you may try in packages/material-top-tab as a seperate package in dooboo-ui.

@hyochan
Copy link
Owner

hyochan commented Oct 18, 2021

Closes due to inactivity.

@hyochan hyochan closed this as completed Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discussion Discuss issues
Projects
None yet
Development

No branches or pull requests

3 participants