Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structlog.stdlib.recreate_defaults #428

Merged
merged 15 commits into from
Jul 20, 2022
Merged

Add structlog.stdlib.recreate_defaults #428

merged 15 commits into from
Jul 20, 2022

Conversation

hynek
Copy link
Owner

@hynek hynek commented Jul 14, 2022

@pradyunsg you asked for this, you're reviewing it. ;)

@hynek hynek changed the title │Add structlog.stdlib.recreate_defaults Add structlog.stdlib.recreate_defaults Jul 14, 2022
@hynek hynek force-pushed the stdlib-recreate branch 2 times, most recently from 8915936 to 7e236fe Compare July 15, 2022 17:15
@hynek hynek force-pushed the stdlib-recreate branch from 7e236fe to 5a3fb90 Compare July 20, 2022 05:47
Copy link
Contributor

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on a quick skim. I can take a closer look over the weekend!

CHANGELOG.md Outdated Show resolved Hide resolved
src/structlog/_config.py Outdated Show resolved Hide resolved
@hynek hynek force-pushed the stdlib-recreate branch from 8fb9f12 to cc2234c Compare July 20, 2022 06:49
Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>
@hynek
Copy link
Owner Author

hynek commented Jul 20, 2022

LGTM, based on a quick skim.

Thanks!

I can take a closer look over the weekend!

Naw, this baby is overdue. 😅

@hynek hynek merged commit a15b71d into main Jul 20, 2022
@hynek hynek deleted the stdlib-recreate branch July 20, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants