Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $HFPR_VERSION substitution #39

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Add $HFPR_VERSION substitution #39

merged 2 commits into from
Dec 30, 2023

Conversation

hynek
Copy link
Owner

@hynek hynek commented Dec 30, 2023

This allows to include the package version in the PyPI readme.

Does this make sense @ofek?

@ofek
Copy link
Contributor

ofek commented Dec 30, 2023

Makes sense, however since this isn't an environment variable where we would have to be cognizant of conflicts, why not $PROJECT_VERSION?

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually right the readme may for some reason contain that string, so this name is fine

@hynek hynek merged commit dde5da2 into main Dec 30, 2023
13 checks passed
@hynek hynek deleted the hfpr-version branch December 30, 2023 17:24
@hynek
Copy link
Owner Author

hynek commented Dec 30, 2023

Cool, thanks!

@henryiii
Copy link

henryiii commented Dec 31, 2023

Would it be possible to give this a default? Scikit-build-core is using this so adding a new required argument broke the plugin. Ideally we should finish dynamic-metadata and then support that directly instead of wrapping it. I can work around it, just would have been nice.

@henryiii
Copy link

FYI, the dynamic-metadata spec currently doesn't have a way to access other metadata values. I wonder if it would be worth trying? It would also be important to make sure version was computed before the other values - in fact, I think it only makes sense for other plugins to be able to see the version, since otherwise you'd need to declare dependencies and topologically sort.

@ofek
Copy link
Contributor

ofek commented Dec 31, 2023

@hynek
Copy link
Owner Author

hynek commented Dec 31, 2023

Aw sorry you need a default for build_text? I can do a 24.1 tomorrow when I’m sober again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants