-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $HFPR_VERSION substitution #39
Conversation
Makes sense, however since this isn't an environment variable where we would have to be cognizant of conflicts, why not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually right the readme may for some reason contain that string, so this name is fine
Cool, thanks! |
Would it be possible to give this a default? Scikit-build-core is using this so adding a new required argument broke the plugin. Ideally we should finish |
FYI, the dynamic-metadata spec currently doesn't have a way to access other metadata values. I wonder if it would be worth trying? It would also be important to make sure version was computed before the other values - in fact, I think it only makes sense for other plugins to be able to see the version, since otherwise you'd need to declare dependencies and topologically sort. |
|
Aw sorry you need a default for build_text? I can do a 24.1 tomorrow when I’m sober again. |
This allows to include the package version in the PyPI readme.
Does this make sense @ofek?