Add local-macros and extend hy.eval and hy.macroexpand
#2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kodiologist
force-pushed
the
local-macros-firstclass
branch
from
f3c97b2 to
3d4f27d
Compare
Kodiologist
force-pushed
the
local-macros-firstclass
branch
from
3d4f27d to
235244c
Compare
Kodiologist
changed the title
local-macroslocal-macros and extend hy.eval and hy.macroexpand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the user can list local macros and get local-macro objects. I've decided it's best not to try to implement adding or deleting local macros dynamically, since that seems messy and of dubious value. So the situation is similar to ordinary variables in Python: the global set is completely dynamic, while the local set is fixed at runtime.
[Edit: the following turned out to be easy enough, so I just added it to this PR.] Next up is allowing
hy.evalto use local macros, perhaps as part of a general faculty to allow the user to pass in a dictionary of macros. Next, perhaps, some extensions tohy.macroexpandandhy.macroexpand-1to control what set of macros they use.