Handle pyreadline failure (Windows + Python 3.10+) #2115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2114
This is a bit hacky, but I'm not sure if there's a better way. I'm confident on the
setup.py
change to avoid even installingpyreadline
on Python 3.10+ (which in itself is enough to fix the problem since then the fallback happens properly), but I added more code to handle theAttributeError
for cases wherepyreadline
gets installed separately and thusimport readline
still pulls it in (I'm not sure which cases actually invoke theimport pyreadline
fallback code -- maybe older versions ofpyreadline
? older versions of Python's built-inreadline
module?).