Fix equality for Hy models

[allison-casey]

closes #1363

• models are no longer equal to equivalent python literals
• models only equal to models of the same kind
• renamed wrap_value -> as_model and exposed under hy module

[Kodiologist]

This must have been a lot of work. Thanks a lot for doing this.

You should now be able to remove several checks of the form isinstance(…, Symbol) that are followed up immediately with an equality test; e.g., in the definiton of hy.model_patterns.sym.

It looks like the change wanted → Symbol(wanted) in the commit labeled "Add: rename wrap_model -> as_model and expose under root hy module" belongs in a different commit.

Recurisvely promote an expr x

The input need not be an expression.

Don't forget the hyphen in "S-expression". That's an important hyphen, especially on gay-pride month. Actually, when talking about Hy, I usually just say "expression", if only because the model type is named Expression. Also, I would avoid the word "unquoted". Be a little more specific, like "values that aren't Hy models".

I think your use of "Python literal" to mean "unboxed value" (i.e., "ordinary value that's not a model") in a commit message and NEWS is confusing. Literals are elements of syntax, not objects.

The last commit mssage says "Docs:", but there are no documentation changes in that commit.

[Kodiologist]

What's with all the additions of __hash__?

Why is Sequence.__eq__ necessary?

[allison-casey]

This must have been a lot of work. Thanks a lot for doing this.

not as long as pattern matching lol, but thats should be done soon just need to reorg the commits

You should now be able to remove several checks of the form isinstance(…, Symbol) that are followed up immediately with an equality test; e.g., in the definiton of hy.model_patterns.sym.

done

It looks like the change wanted → Symbol(wanted) in the commit labeled "Add: rename wrap_model -> as_model and expose under root hy module" belongs in a different commit.

Moved to correct commit

The input need not be an expression.

rephrased as "object"

Don't forget the hyphen in "S-expression". That's an important hyphen, especially on gay-pride month. Actually, when talking about Hy, I usually just say "expression", if only because the model type is named Expression. Also, I would avoid the word "unquoted". Be a little more specific, like "values that aren't Hy models".

Hy says gay rights 🏳️‍🌈
rephrased to be "expression", "non-hy model objects", and "associated Python values"

What's with all the additions of hash?

When you overwrite the __eq__ method of an immutable type it loses its hashability so you have to redefine it. made __hash__ an inherited method of Object to clean things up.

Why is Sequence.eq necessary?

Its not. removed

[Kodiologist]

I've edited the PR to:

• Remove a stray whitespace edit.
• Capitalize "Hy" in prose.
• Remove more Symbol type checks.