Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hungarian interface #141

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

hyesungoh
Copy link
Owner

@hyesungoh hyesungoh commented Jun 1, 2023

Description

replacee hungarian interface to normal interface, IFoo to Foo

@vercel
Copy link

vercel bot commented Jun 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
comet-land-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 4:10am
comet-land-resume ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 4:10am

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8c8c659) 91.62% compared to head (e79210b) 91.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         104      104           
  Lines        2948     2948           
  Branches      536      536           
=======================================
  Hits         2701     2701           
  Misses        247      247           
Impacted Files Coverage Δ
apps/blog/src/components/TOC/TOC.tsx 95.45% <100.00%> (ø)
apps/blog/src/utils/getHeadings.ts 95.83% <100.00%> (ø)
apps/resume/src/components/Header/Header.tsx 100.00% <100.00%> (ø)
...c/components/OtherExperienceSection/Experience.tsx 100.00% <100.00%> (ø)
.../OtherExperienceSection/OtherExperienceSection.tsx 100.00% <100.00%> (ø)
apps/resume/src/components/SkillsSection/Skill.tsx 100.00% <100.00%> (ø)
...ume/src/components/SkillsSection/SkillsSection.tsx 100.00% <100.00%> (ø)
...e/src/components/WorkExperienceSection/Company.tsx 100.00% <100.00%> (ø)
...e/src/components/WorkExperienceSection/Project.tsx 100.00% <100.00%> (ø)
...ts/WorkExperienceSection/WorkExperienceSection.tsx 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Jun 1, 2023

Passing run #155 ↗︎

0 27 0 0 Flakiness 0

Details:

Merge e79210b into 8c8c659...
Project: blog Commit: 8cbec7b5d3 ℹ️
Status: Passed Duration: 01:10 💡
Started: Jun 1, 2023 4:10 AM Ended: Jun 1, 2023 4:12 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Jun 1, 2023

Passing run #145 ↗︎

0 16 0 0 Flakiness 0

Details:

Merge e79210b into 8c8c659...
Project: resume Commit: 8cbec7b5d3 ℹ️
Status: Passed Duration: 00:21 💡
Started: Jun 1, 2023 4:13 AM Ended: Jun 1, 2023 4:13 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@hyesungoh hyesungoh merged commit 68e55f3 into main Jun 1, 2023
@hyesungoh hyesungoh deleted the refactor/delete-hungarian-interface branch June 1, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: blog About blog area: resume About resume refactor This seems like refactorable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant