Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal error: 'CoreMidi/CoreMidi.h' file not found #1865

Closed
ryandesign opened this issue Oct 6, 2023 · 3 comments
Closed

fatal error: 'CoreMidi/CoreMidi.h' file not found #1865

ryandesign opened this issue Oct 6, 2023 · 3 comments
Labels
Milestone

Comments

@ryandesign
Copy link

Hydrogen version * : 1.2.2
Operating system + version : macOS (any)
Audio driver + version : N/A


CoreMIDI is miscapitalized in the source code, resulting in build failure on case-sensitive filesystems:

hydrogen-1.2.2/src/core/IO/CoreMidiDriver.h:36:10: fatal error: 'CoreMidi/CoreMidi.h' file not found
#include <CoreMidi/CoreMidi.h>
         ^~~~~~~~~~~~~~~~~~~~~
1 error generated.

@theGreatWhiteShark
Copy link
Contributor

Hey @ryandesign ,

resulting in build failure on case-sensitive filesystems

Are case-sensitive filesystems something introduced recently to macOS? This include was not touched in 14 years and the build runs smooth in our AppVeyor macOS pipeline.

(Disclaimer: I'm not a macOS person and have not access to it other than our build pipeline)

@cme
Copy link
Contributor

cme commented Oct 6, 2023

Case sensitive filesystems have always been an option in OSX but the default is for HFS/APFS to be case-insensitive, no it's not surprising this got missed!

Good catch.

@theGreatWhiteShark
Copy link
Contributor

So, the proper version is

#include <CoreMIDI/CoreMIDI.h>

?

theGreatWhiteShark added a commit to theGreatWhiteShark/hydrogen that referenced this issue Oct 25, 2023
theGreatWhiteShark added a commit to theGreatWhiteShark/hydrogen that referenced this issue Oct 29, 2023
@theGreatWhiteShark theGreatWhiteShark added this to the 1.2.3 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants