Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Midi Notes up to 127 in Instrument MIDI Output #1828

Closed
PatDyn opened this issue Jul 29, 2023 · 3 comments · Fixed by #1829
Closed

Allow Midi Notes up to 127 in Instrument MIDI Output #1828

PatDyn opened this issue Jul 29, 2023 · 3 comments · Fixed by #1829

Comments

@PatDyn
Copy link

PatDyn commented Jul 29, 2023

Hydrogen version * : 1.2.1-1
Operating system + version : Manjaro, installed via pamac
Audio driver + version : Jack, 1.9.22

I've been using hydrogen along with a launch pad mini, using its buttons to mute/unmute instruments in H2.
Having the midi note output is incredibly helpful as it visual feedback for the currently playing instruments on the launchpad.

However, this is limited by the cap on the MIDI note number output. That means visual feedback of playing instruments stops
in the middle of a row of buttons. Is there any specific reason why there is a limit? Or would it be possible to remove the cap and make all note numbers available for output?

  • H2 version : see 'Info > About' in the GUI or 'hydrogen -v' on the command line. Also, please indicate how you installed it, e.g. binary downloaded from SourceForge/Github, brew (macOS), OS repo (Linux), flathub (Linux).
    ** if you are reporting a bug, please describe how the bug can be reproduced
theGreatWhiteShark added a commit to theGreatWhiteShark/hydrogen that referenced this issue Jul 31, 2023
@theGreatWhiteShark
InstrumentEditor: fix Midi Out Note range
d5b494d 
By accident I limited the range of possible MIDI output notes to `100` in 1.2.0.

The supported range is now [0,127] again.

Fixes hydrogen-music#1828
@theGreatWhiteShark theGreatWhiteShark mentioned this issue Jul 31, 2023
Merged
@theGreatWhiteShark
Copy link
Contributor

Is there any specific reason why there is a limit?

No. That's a bug. Thanks for reporting!

theGreatWhiteShark added a commit that referenced this issue Jul 31, 2023
@theGreatWhiteShark
InstrumentEditor: fix Midi Out Note range
a5ebea3 
By accident I limited the range of possible MIDI output notes to `100` in 1.2.0.

The supported range is now [0,127] again.

Fixes #1828
@theGreatWhiteShark
Copy link
Contributor

The fix will be part of the 1.2.2 patch release.

If you could check the fix in either the releases/1.2 branch or in the latest developer version on master, this would be great.

@PatDyn
Copy link
Author

PatDyn commented Aug 11, 2023

Thanks! I built from master and everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

InstrumentEditor: fix Midi Out Note range theGreatWhiteShark/hydrogen
2 participants
@theGreatWhiteShark @PatDyn