-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BPM counter resets to 120 bpm #1785
Comments
That's probably #1781. Could you build the latest code from branch |
Just tried latest master. Still seems to happen. Both when switching from song to pattern and from pattern to song. It's not systematic: it happens like 50% of the time, but it's very easy to reproduce. Just create a new project, set BPM to 160, switch to song mode and it will jump back to 120. Set again 160, switch to pattern mode and it's very likely to jump again to 120, and so on. Also with the current master there is a slightly different variation: sometimes the bpm counter remains at the correct value (160) but the playback speed switches to 120 bpm (so the UI and the playback do not agree). |
Ah, okay. Interesting. I'll try to reproduce it during the next couple of days. |
A dedicated method for handling switching between pattern and song mode was introduced. Previously, the `AudioEngine` was reset but the song tempo was not reintroduced.
@pragmaware there was indeed still a bug I missed. Could you check whether #1788 fixes this issue at your end? |
AudioEngine: fix mode change tempo glitches (#1785)
A dedicated method for handling switching between pattern and song mode was introduced. Previously, the `AudioEngine` was reset but the song tempo was not reintroduced.
Hydrogen version * : 1.2.0 - self compiled from git
Operating system + version : linux - ubuntu 23.04
Audio driver + version : does not matter
When switching to pattern mode from song mode the BPM counter always resets to 120 bpm.
It should either stay at the bpm currently set in the song or eventually return to the bpm that was set when the pattern was edited.
The text was updated successfully, but these errors were encountered: