Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPM counter resets to 120 bpm #1785

Closed
pragmaware opened this issue May 26, 2023 · 4 comments · Fixed by #1788
Closed

BPM counter resets to 120 bpm #1785

pragmaware opened this issue May 26, 2023 · 4 comments · Fixed by #1788

Comments

@pragmaware
Copy link

Hydrogen version * : 1.2.0 - self compiled from git
Operating system + version : linux - ubuntu 23.04
Audio driver + version : does not matter


When switching to pattern mode from song mode the BPM counter always resets to 120 bpm.

It should either stay at the bpm currently set in the song or eventually return to the bpm that was set when the pattern was edited.

@theGreatWhiteShark
Copy link
Contributor

That's probably #1781. Could you build the latest code from branch master (or releases/1.2) and check whether this issue still occurs?

@pragmaware
Copy link
Author

Just tried latest master.

Still seems to happen. Both when switching from song to pattern and from pattern to song. It's not systematic: it happens like 50% of the time, but it's very easy to reproduce. Just create a new project, set BPM to 160, switch to song mode and it will jump back to 120. Set again 160, switch to pattern mode and it's very likely to jump again to 120, and so on.

Also with the current master there is a slightly different variation: sometimes the bpm counter remains at the correct value (160) but the playback speed switches to 120 bpm (so the UI and the playback do not agree).

@theGreatWhiteShark
Copy link
Contributor

Ah, okay. Interesting. I'll try to reproduce it during the next couple of days.

theGreatWhiteShark added a commit to theGreatWhiteShark/hydrogen that referenced this issue May 29, 2023
A dedicated method for handling switching between pattern and song mode was introduced. Previously, the `AudioEngine` was reset but the song tempo was not reintroduced.
@theGreatWhiteShark
Copy link
Contributor

@pragmaware there was indeed still a bug I missed.

Could you check whether #1788 fixes this issue at your end?

theGreatWhiteShark added a commit that referenced this issue May 31, 2023
AudioEngine: fix mode change tempo glitches (#1785)
theGreatWhiteShark added a commit that referenced this issue May 31, 2023
A dedicated method for handling switching between pattern and song mode was introduced. Previously, the `AudioEngine` was reset but the song tempo was not reintroduced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants