-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest 1.2.0 release fails to build with "format not a string literal" #1739
Comments
Hey @david-geiger , I can reproduce it. Compilation fails due to the compiler flag I'll review the compiler flags we use and some more warnings and more strict behavior is most probably a good thing to have. But for now I would suggest you compile without the flag till the next release. P.S. In your log there are some patches applied to the source code which look outdated and make me wonder why they were necessary in the first place. Do you have any insights into this matter? |
Ok so I disable the werror=format-security flag during build adding "Wno-error=format-security" and waiting for a fix in next release. For the patches one is for fix a python3 shebangs: and the other for the desktop file but I see that I can drop it now (it is not really necessary): |
I'll apply those changes in our codebase too. |
Could you check whether your toolchain is able to build the source code in #1746? |
Apply patch to fix format string issue: hydrogen-music/hydrogen#1739 git-svn-id: file:///srv/repos/svn-community/svn@1446677 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Apply patch to fix format string issue: hydrogen-music/hydrogen#1739 git-svn-id: file:///srv/repos/svn-community/svn@1446677 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Hi,
I tried on Mageia Linux Cauldron to build latest 1.2.0 release but it fails to build with an error "format not a string literal":
Attached full build log
log.hydrogen.txt
The text was updated successfully, but these errors were encountered: