chore: Rename Hydroflow -> DFIR #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydroflow with
|
| Latest commit: |
f4da6ed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://141b77f0.hydroflow.pages.dev |
| Branch Preview URL: | https://rohit-hf-rename.hydroflow.pages.dev |
rohitkulshreshtha
requested review from
jhellerstein
and removed request for
zzlk
rohitkulshreshtha
force-pushed
the
rohit_hf_rename
branch
from
1c507d8 to
126493b
Compare
rohitkulshreshtha
force-pushed
the
rohit_hf_rename
branch
from
f640f4d to
b697b20
Compare
rohitkulshreshtha
force-pushed
the
rohit_hf_rename
branch
from
b697b20 to
f4da6ed
Compare
|
The diff seems to introduce a lot new lines without removing old |
rohitkulshreshtha
changed the title
Not sure. Files have been moved - how are those accounted in statistics? |
|
Moves shouldn't count. My hunch is there are new snapshot files but old ones haven't been cleaned up? Because snapshot file names include the crate name. |
Comment on lines
+89
to
+90
| hydroflow dfir_lang dfir_macro hydroflow_plus | ||
| hydroflow_plus_std dfir_datalog dfir_datalog_core |
There was a problem hiding this comment.
Seems the hydroflow_plus ones here didn't get updated
| @@ -10,11 +10,11 @@ The Hydroflow repo is set up as a monorepo and [Cargo workspace](https://doc.rus | |||
| Relative to the repository root: | |||
|
|
|||
| * `hydroflow` is the main Hydroflow package, containing the Hydroflow runtime. It re-exports the | |||
|
Oops - this didn't go into main |
MingweiSamuel
pushed a commit
that referenced
this pull request
Dec 22, 2024
Work In Progress: - [x] hydroflow_macro - [x] hydroflow_datalog_core - [x] hydroflow_datalog - [x] hydroflow_lang - [x] hydroflow
MingweiSamuel
added a commit
that referenced
this pull request
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress: