refactor!: use cfg(nightly) instead of feature, remove -Z flag, use Diagnostic::try_emit
#1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MingweiSamuel
changed the title
cfg(nightly) instead of nightlycfg(nightly) instead of feature, Diagnostic::try_emit
MingweiSamuel
force-pushed
the
nightly-no-feature
branch
2 times, most recently
from
d097dd4 to
358632e
Compare
MingweiSamuel
force-pushed
the
nightly-no-feature
branch
from
a42c30e to
366e402
Compare
MingweiSamuel
changed the title
cfg(nightly) instead of feature, Diagnostic::try_emitcfg(nightly) instead of feature, remove -Z flag, use Diagnostic::try_emit
MingweiSamuel
changed the title
cfg(nightly) instead of feature, remove -Z flag, use Diagnostic::try_emitcfg(nightly) instead of feature, remove -Z flag, use Diagnostic::try_emit
shadaj
reviewed
Dec 11, 2024
shadaj
approved these changes
Dec 11, 2024
MingweiSamuel
commented
Dec 12, 2024
MingweiSamuel
force-pushed
the
nightly-no-feature
branch
from
781c408 to
566c688
Compare
shadaj
reviewed
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR (#1587) website build did not work because
panic = "abort"is set on wasm, leading to aborts forproc_macro2::Span::unwrap()calls.All tests except trybuild seem to pass on stable, WIP #1587 next
BREAKING CHANGE: replaces
hydroflow_lang::diagnostic::Diagnostic::emitwithtry_emitBREAKING CHANGE: removes features:
hydroflow/nightly,hydroflow_datalog/diagnostics,hydroflow_datalog_core/diagnostics,hydroflow_lang/diagnostics,hydroflow_macro/diagnostics,hydroflow_plus/diagnostics.