[columnar] [Bug]: Vacuum still fails by hanging indefinitely #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During vacuum, stripes are collected in reverse order and if row number is greater than defined limit we should stop and combine previous stripe into them into one. Problem is that while writing rows into temporary write state object - this condition is not greater but greater or equal which lead to infinite loop. Fixed by using proper comparison operator when stripe candidates are choosen.
wuputah
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During vacuum, stripes are collected in reverse order and if row number is greater than defined limit we should stop and combine previous stripe into them into one. Problem is that while writing rows into temporary write state object - this condition is not greater but greater or equal which lead to infinite loop. Fixed by using proper comparison operator when stripe candidates are choosen.
What's changed?