[columnar] [Bug]: Vacuum still fails by hanging indefinitely

During vacuum, stripes are collected in reverse order and if row number is greater than defined limit we should stop and combine previous stripe into them into one. Problem is that while writing rows into temporary write state object - this condition is not greater but greater or equal which lead to infinite loop. Fixed by using proper comparison operator when stripe candidates are choosen.
hydradatabase · May 16, 2023 · 65fb1f3 · 65fb1f3
1 parent ac1c5bd
commit 65fb1f3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/columnar/src/backend/columnar/columnar_metadata.c b/columnar/src/backend/columnar/columnar_metadata.c
@@ -1362,7 +1362,7 @@ ReadChunkGroupRowCounts(uint64 storageId, uint64 stripe, uint32 chunkGroupCount,
 	HeapTuple heapTuple = NULL;
 
 	*chunkGroupRowCounts = palloc0(chunkGroupCount * sizeof(uint32));
-	*chunkGroupDeletedRows = palloc(chunkGroupCount * sizeof(uint32));
+	*chunkGroupDeletedRows = palloc0(chunkGroupCount * sizeof(uint32));
 
 	/*
 	 * Since we have now updates of `chunk_group`, there could be multiple tuples

diff --git a/columnar/src/backend/columnar/columnar_tableam.c b/columnar/src/backend/columnar/columnar_tableam.c
@@ -1181,7 +1181,7 @@ TruncateAndCombineColumnarStripes(Relation rel, int elevel)
 
 		uint64 stripeRowCount = stripeMetadata->rowCount - lastStripeDeletedRows;
 
-		if ((totalRowNumberCount + stripeRowCount > columnarOptions.stripeRowCount))
+		if ((totalRowNumberCount + stripeRowCount >= columnarOptions.stripeRowCount))
 		{
 			break;
 		}
-Original file line number
+Diff line change
@@ Expand Up @@
     		uint64 stripeRowCount = stripeMetadata->rowCount - lastStripeDeletedRows;
-    		if ((totalRowNumberCount + stripeRowCount > columnarOptions.stripeRowCount))
+    		if ((totalRowNumberCount + stripeRowCount >= columnarOptions.stripeRowCount))
     		{
     			break;
     		}
@@ Expand Down @@